Repository navigation
Summarize CDN caching; record decision against purge callback - #3130
Merged
Merged
Conversation
docs/implementation.md now has a short "CDN caching" section: what the CDN caches (badges and JSON, anonymous project pages, "unchanging" pages), the kill switches, how we purge, and how static files are cached (immutable only for fingerprinted URLs). It points to cdn-cache-not-logged-in.md for the design details. Section 11 of cdn-cache-not-logged-in.md read as pending future work, but we've decided not to purge from a model callback: the callback wouldn't fire for the callback-skipping writes it was meant to catch, and those writes change only BOOKKEEPING_FIELDS, which no cached page shows. Section 11 now leads with that decision; the original analysis stays below it. We updated the references to it. Also fix the documented purge command: the task is fastly:purge_all, not fastly:purge. Assisted-by: Claude:claude-opus-5-5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3130 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 90 90
Lines 4818 4818
=========================================
Hits 4818 4818 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/implementation.md now has a short "CDN caching" section: what the CDN caches (badges and JSON, anonymous project pages, "unchanging" pages), the kill switches, how we purge, and how static files are cached (immutable only for fingerprinted URLs). It points to cdn-cache-not-logged-in.md for the design details.
Section 11 of cdn-cache-not-logged-in.md read as pending future work, but we've decided not to purge from a model callback: the callback wouldn't fire for the callback-skipping writes it was meant to catch, and those writes change only BOOKKEEPING_FIELDS, which no cached page shows. Section 11 now leads with that decision; the original analysis stays below it. We updated the references to it.
Also fix the documented purge command: the task is fastly:purge_all, not fastly:purge.
Assisted-by: Claude:claude-opus-5-5